SLOP-376: port legacy Revision class to RevisionStore (removed in MW 1.39) - #11
Open
tosfos wants to merge 1 commit into
Open
SLOP-376: port legacy Revision class to RevisionStore (removed in MW 1.39)#11tosfos wants to merge 1 commit into
tosfos wants to merge 1 commit into
Conversation
…1.39) Revision::newFromRow/newFromTitle and the Revision class itself were removed in MediaWiki 1.39. Port all six call sites: - newFromRow -> RevisionStore::newRevisionFromRow - ->getPrevious() -> RevisionStore::getPreviousRevision - newFromTitle -> RevisionStore::getKnownCurrentRevision
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
Revisionclass was removed in MediaWiki 1.39 (deprecated since 1.31). Six live call sites fatal on 1.39 withClass 'Revision' not found:includes/ReviewHandler.php:156,167—Revision::newFromRow(...)->getPrevious(),Revision::newFromTitle(...)specials/SpecialPendingReviews.php:308,476,497,915— same patternsPorted to the service-locator equivalents:
Revision::newFromRow( $row )→MediaWikiServices::getInstance()->getRevisionStore()->newRevisionFromRow( $row )->getPrevious()→RevisionStore::getPreviousRevision( $record )Revision::newFromTitle( $title )→RevisionStore::getKnownCurrentRevision( $title )(null-guarded before->getId())Verification
php -lclean on php:7.4-cli and php:8.2-cli for both files.Revision::references (commented sites untouched).Closes SLOP-376.